Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): set kubebuilder assets directory (backport #3577) #3596

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 20, 2021

This is an automatic backport of pull request #3577 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

The `dev/tools` make target installs testing dependencies into
$CI_TOOLS_DIR, but the wiring between this and the kubebuilder envtest
framework was broken. Make sure that we set the `KUBEBUILDER_ASSETS`
environment variable so that the envtest framework can find its
dependencies correctly.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit a9b64a3)
@mergify mergify bot requested a review from a team as a code owner December 20, 2021 22:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #3596 (cb64222) into release-1.4 (2c0d80f) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.4    #3596      +/-   ##
===============================================
+ Coverage        51.97%   52.01%   +0.03%     
===============================================
  Files              905      905              
  Lines            54684    54684              
===============================================
+ Hits             28422    28442      +20     
+ Misses           23982    23961      -21     
- Partials          2280     2281       +1     
Impacted Files Coverage Δ
pkg/core/resources/manager/cache.go 85.71% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/insights/resyncer.go 73.61% <0.00%> (+2.45%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (+5.12%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c0d80f...cb64222. Read the comment docs.

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) December 21, 2021 18:04
@michaelbeaumont michaelbeaumont merged commit c53d25c into release-1.4 Dec 21, 2021
@michaelbeaumont michaelbeaumont deleted the mergify/bp/release-1.4/pr-3577 branch December 21, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants